From 0709b9f65084bdf096fa7bae6667abcde9e30d79 Mon Sep 17 00:00:00 2001 From: Matthew Wolter Date: Sun, 12 Apr 2026 04:51:06 -0700 Subject: [PATCH] =?UTF-8?q?G7:=20F13=20=E2=80=94=20remove=20broken=20depre?= =?UTF-8?q?cated=20req=5Fmma=20method?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Why: req_mma() references undefined variables `start` and `end`, causing a NameError on every call. The logger.error migration warning confirms the method is intentionally deprecated in favor of req_mma_sync. Since it is broken as shipped, removing it cannot break any working caller. Refs: Forensics report finding F13 --- src/meshcore/commands/binary.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/meshcore/commands/binary.py b/src/meshcore/commands/binary.py index f1578d0..5720a26 100644 --- a/src/meshcore/commands/binary.py +++ b/src/meshcore/commands/binary.py @@ -73,10 +73,6 @@ class BinaryCommandHandler(CommandHandlerBase): return telem_event.payload["lpp"] if telem_event else None - async def req_mma(self, contact, timeout=0, min_timeout=0): - logger.error("*** please consider using req_mma_sync instead of req_mma") - return await self.req_mma_sync(contact, start, end, timeout,min_timeout) - async def req_mma_sync(self, contact, start, end, timeout=0,min_timeout=0): async with self._mesh_request_lock: req = (