From 09ff8771d8c6540f14e5d897e17fa0fc790add64 Mon Sep 17 00:00:00 2001 From: liamcottle Date: Tue, 11 Feb 2025 23:42:58 +1300 Subject: [PATCH] use base class methods for disconnected event --- src/connection/ble_connection.js | 2 +- src/connection/connection.js | 4 ++++ src/connection/serial_connection.js | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/connection/ble_connection.js b/src/connection/ble_connection.js index 882ce68..fdc1ab1 100644 --- a/src/connection/ble_connection.js +++ b/src/connection/ble_connection.js @@ -44,7 +44,7 @@ class BleConnection extends Connection { // listen for ble disconnect this.bleDevice.addEventListener("gattserverdisconnected", () => { - this.emit("disconnected"); + this.onDisconnected(); }); // connect to gatt server diff --git a/src/connection/connection.js b/src/connection/connection.js index 3c98d64..d023849 100644 --- a/src/connection/connection.js +++ b/src/connection/connection.js @@ -9,6 +9,10 @@ class Connection extends EventEmitter { this.emit("connected"); } + onDisconnected() { + this.emit("disconnected"); + } + async close() { throw new Error("This method must be implemented by the subclass."); } diff --git a/src/connection/serial_connection.js b/src/connection/serial_connection.js index c941875..06b5d20 100644 --- a/src/connection/serial_connection.js +++ b/src/connection/serial_connection.js @@ -17,7 +17,7 @@ class SerialConnection extends Connection { // listen for disconnect this.serialPort.addEventListener("disconnect", () => { - this.emit("disconnected"); + this.onDisconnected(); }); // fire connected callback after constructor has returned