cppcheck fixes

This commit is contained in:
Peter Buchegger 2021-01-03 00:15:08 +01:00
parent 47a4455145
commit 32a201b980
6 changed files with 24 additions and 20 deletions

View file

@ -15,9 +15,9 @@ BoardConfig::BoardConfig(
{
}
BoardFinder::BoardFinder(std::list<std::shared_ptr<BoardConfig>> boardConfigs)
BoardFinder::BoardFinder(std::list<std::shared_ptr<BoardConfig>> & boardConfigs)
: _boardConfigs(boardConfigs)
{
_boardConfigs = boardConfigs;
}
std::shared_ptr<BoardConfig> BoardFinder::searchBoardConfig()

View file

@ -23,7 +23,7 @@ enum BoardType
class BoardConfig
{
public:
BoardConfig(
explicit BoardConfig(
String name, BoardType type,
uint8_t oledsda, uint8_t oledscl, uint8_t oledaddr, uint8_t oledreset,
uint8_t lorasck, uint8_t loramiso, uint8_t loramosi, uint8_t loracs, uint8_t lorareset, uint8_t lorairq,
@ -51,7 +51,7 @@ public:
class BoardFinder
{
public:
BoardFinder(std::list<std::shared_ptr<BoardConfig>> boardConfigs);
explicit BoardFinder(std::list<std::shared_ptr<BoardConfig>> & boardConfigs);
std::shared_ptr<BoardConfig> searchBoardConfig();

View file

@ -28,11 +28,11 @@ class NTPClient {
public:
NTPClient();
NTPClient(long timeOffset);
NTPClient(const char* poolServerName);
explicit NTPClient(long timeOffset);
explicit NTPClient(const char* poolServerName);
NTPClient(const char* poolServerName, long timeOffset);
NTPClient(const char* poolServerName, long timeOffset, unsigned long updateInterval);
NTPClient(IPAddress poolServerIP);
explicit NTPClient(IPAddress poolServerIP);
NTPClient(IPAddress poolServerIP, long timeOffset);
NTPClient(IPAddress poolServerIP, long timeOffset, unsigned long updateInterval);