From fda9ff96c25a10a3b477f825c5b8a9bdac3a65de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20K=C3=A4berich?= Date: Tue, 9 Dec 2025 13:43:21 +0100 Subject: [PATCH] bugfix: capture by reference --- .../PC_Application/LibreVNA-GUI/Calibration/calkit.cpp | 2 +- Software/PC_Application/LibreVNA-GUI/scpi.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Software/PC_Application/LibreVNA-GUI/Calibration/calkit.cpp b/Software/PC_Application/LibreVNA-GUI/Calibration/calkit.cpp index 3b24352..652fa5c 100644 --- a/Software/PC_Application/LibreVNA-GUI/Calibration/calkit.cpp +++ b/Software/PC_Application/LibreVNA-GUI/Calibration/calkit.cpp @@ -462,7 +462,7 @@ void Calkit::updateSCPINames() scpi_std.remove(s); } unsigned int i=1; - for(auto &s : standards) { + for(auto s : standards) { s->changeName(QString::number(i)); scpi_std.add(s); i++; diff --git a/Software/PC_Application/LibreVNA-GUI/scpi.cpp b/Software/PC_Application/LibreVNA-GUI/scpi.cpp index f0a0995..aadf43b 100644 --- a/Software/PC_Application/LibreVNA-GUI/scpi.cpp +++ b/Software/PC_Application/LibreVNA-GUI/scpi.cpp @@ -318,7 +318,7 @@ bool SCPINode::addUnsignedIntParameter(QString name, unsigned int ¶m, bool g return SCPI::getResultName(SCPI::Result::Error); } } : (std::function) nullptr; - auto query = gettable ? [=](QStringList params) -> QString { + auto query = gettable ? [¶m](QStringList params) -> QString { Q_UNUSED(params) return QString::number(param); } : (std::function) nullptr; @@ -337,7 +337,7 @@ bool SCPINode::addBoolParameter(QString name, bool ¶m, bool gettable, bool s return SCPI::getResultName(SCPI::Result::Error); } } : (std::function) nullptr; - auto query = gettable ? [=](QStringList params) -> QString { + auto query = gettable ? [¶m](QStringList params) -> QString { Q_UNUSED(params) return param ? SCPI::getResultName(SCPI::Result::True) : SCPI::getResultName(SCPI::Result::False); } : (std::function) nullptr; @@ -357,11 +357,11 @@ bool SCPINode::addStringParameter(QString name, QString ¶m, bool gettable, b return SCPI::getResultName(SCPI::Result::Error); } } : (std::function) nullptr; - auto query = gettable ? [=](QStringList params) -> QString { + auto query = gettable ? [¶m](QStringList params) -> QString { Q_UNUSED(params) return param; } : (std::function) nullptr; - return add(new SCPICommand(name, cmd, query)); + return add(new SCPICommand(name, cmd, query, false)); } bool SCPINode::changeName(QString newname)