jankae/LibreVNA
1
0
Fork 0
mirror of https://github.com/jankae/LibreVNA.git synced 2026-01-21 08:00:23 +01:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

prevent crash in packet log view with invalid values

Browse source
This commit is contained in:
Jan Käberich 2026-01-20 13:11:08 +01:00
parent 6b4bf83320
commit 5ce342d2db
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Software/PC_Application/LibreVNA-GUI/Device/LibreVNA/devicepacketlogview.cpp
View file

@ -114,9 +114,14 @@ void DevicePacketLogView::addEntry(const DevicePacketLog::LogEntry &e)
"ClearFlash", "PerformFirmwareUpdate", "Nack", "Reference", "Generator", "SpectrumAnalyzerSettings",
"SpectrumAnalyzerResult", "RequestDeviceInfo", "RequestSourceCal", "RequestReceiverCal", "SourceCalPoint",
"ReceiverCalPoint", "SetIdle", "RequestFrequencyCorrection", "FrequencyCorrection", "RequestDeviceConfiguration",
"DeviceConfiguration", "DeviceStatus", "RequestDeviceStatus", "VNADatapoint", "SetTrigger", "ClearTrigger"};
"DeviceConfiguration", "DeviceStatus", "RequestDeviceStatus", "VNADatapoint", "SetTrigger", "ClearTrigger",
"StopStatusUpdates", "StartStatusUpdates", "InitiateSweep", "PerformAction", "ResetDeviceConfiguration"};
item->setData(3, Qt::DisplayRole, "Type "+QString::number((int)e.p->type)+"("+packetNames[(int)e.p->type]+")");
if(int(e.p->type) < packetNames.size()) {
item->setData(3, Qt::DisplayRole, "Type "+QString::number((int)e.p->type)+"("+packetNames[(int)e.p->type]+")");
} else {
item->setData(3, Qt::DisplayRole, "Type "+QString::number((int)e.p->type)+"(Unknown)");
}
auto addDouble = [=](QTreeWidgetItem *parent, QString name, double value, QString unit = "", int precision = 8) {
auto subitem = new QTreeWidgetItem;
subitem->setData(2, Qt::DisplayRole, name);
@ -138,7 +143,11 @@ void DevicePacketLogView::addEntry(const DevicePacketLog::LogEntry &e)
auto addEnum = [=](QTreeWidgetItem *parent, QString name, int value, QStringList names) {
auto subitem = new QTreeWidgetItem;
subitem->setData(2, Qt::DisplayRole, name);
subitem->setData(3, Qt::DisplayRole, names[value]);
if(value < names.size()) {
subitem->setData(3, Qt::DisplayRole, names[value]);
} else {
subitem->setData(3, Qt::DisplayRole, "Invalid setting (value="+QString::number(value)+")");
}
parent->addChild(subitem);
};
auto addString = [=](QTreeWidgetItem *parent, QString name, QString value) {