jankae/LibreVNA
1
0
Fork 0
mirror of https://github.com/jankae/LibreVNA.git synced 2026-04-10 17:03:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix impedance renormalization + add unit tests

Browse source
This commit is contained in:
Jan Käberich 2025-02-09 12:59:11 +01:00
parent 523946447a
commit 50bde261af
9 changed files with 114 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Software/PC_Application/LibreVNA-Test/utiltests.cpp
View file

@ -78,3 +78,31 @@ void UtilTests::FirmwareComparison()
QVERIFY(Util::firmwareEqualOrHigher("2.2.2", "2.3") == false);
QVERIFY(Util::firmwareEqualOrHigher("2.2", "2.3.1") == false);
}
void UtilTests::ImpedanceSparameterCalculation()
{
// Check impedance to S parameter conversion and back for different values
auto Z = std::complex<double>(50.0);
auto S = Util::ImpedanceToSparam(Z);
QVERIFY(S == 0.0);
QVERIFY(Util::SparamToImpedance(S) == Z);
Z = std::complex<double>(0.0);
S = Util::ImpedanceToSparam(Z);
QVERIFY(S == -1.0);
QVERIFY(Util::SparamToImpedance(S) == Z);
Z = std::complex<double>(100.0);
S = Util::ImpedanceToSparam(Z);
QVERIFY(qFuzzyCompare(S.real(), 1.0/3));
QVERIFY(S.imag() == 0.0);
QVERIFY(qFuzzyCompare(Util::SparamToImpedance(S).real(), Z.real()));
QVERIFY(qFuzzyCompare(Util::SparamToImpedance(S).imag(), Z.imag()));
// Edge case: convert S parameter to impedance at 1.0 (which will give a +inf impedance)
S = 1.0;
Z = Util::SparamToImpedance(S);
// convert back, we must land back at 1.0
auto S_from_Z = Util::ImpedanceToSparam(Z);
QVERIFY(S_from_Z == S);
}