g4klx/MMDVMHost
1
0
Fork 0
mirror of https://github.com/g4klx/MMDVMHost.git synced 2025-12-06 05:32:00 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rationalise the pseudo tty handling.

Browse source
This commit is contained in:
Jonathan Naylor 2020-06-27 22:33:24 +01:00
parent bdb1c49bae
commit d1a809808b
4 changed files with 120 additions and 188 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

112
PseudoTTYController.cpp
View file

@ -36,8 +36,9 @@
#include <pty.h> #include <pty.h>
CPseudoTTYController::CPseudoTTYController(const std::string& device, unsigned int speed, bool assertRTS) : CPseudoTTYController::CPseudoTTYController(const std::string& symlink, unsigned int speed, bool assertRTS) :
CSerialController(device, speed, assertRTS) CSerialController("", speed, assertRTS),
m_symlink(symlink)
{ {
} }
@ -50,114 +51,35 @@ bool CPseudoTTYController::open()
assert(m_fd == -1); assert(m_fd == -1);
int slavefd; int slavefd;
char buf[300]; char slave[300];
int result = ::openpty(&m_fd, &slavefd, buf, NULL,NULL); int result = ::openpty(&m_fd, &slavefd, slave, NULL, NULL);
if (result < 0) { if (result < 0) {
LogError("Cannot open device - %s - Errno : %d", m_device.c_str(), errno); LogError("Cannot open the pseudo tty - errno : %d", errno);
return false; return false;
} }
std::string slave = std::string(::ptsname(m_fd));
// Remove any previous stale symlink // Remove any previous stale symlink
::unlink(m_device.c_str()); ::unlink(m_symlink.c_str());
int ret = ::symlink(slave.c_str(), m_device.c_str()); int ret = ::symlink(slave, m_symlink.c_str());
if (ret != 0) { if (ret != 0) {
LogError("Cannot make symlink to %s with %s", slave.c_str(), m_device.c_str()); LogError("Cannot make symlink to %s with %s", slave, m_symlink.c_str());
close(); close();
return false; return false;
} }
LogMessage("Made symbolic link from %s to %s", slave, m_symlink.c_str());
m_device = std::string(::ttyname(m_fd)); m_device = std::string(::ttyname(m_fd));
if (::isatty(m_fd)) { return setRaw();
termios termios; }
if (::tcgetattr(m_fd, &termios) < 0) {
LogError("Cannot get the attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
termios.c_iflag &= ~(IGNBRK | BRKINT | IGNPAR | PARMRK | INPCK); void CPseudoTTYController::close()
termios.c_iflag &= ~(ISTRIP | INLCR | IGNCR | ICRNL); {
termios.c_iflag &= ~(IXON | IXOFF | IXANY); CSerialController::close();
termios.c_oflag &= ~(OPOST);
termios.c_cflag &= ~(CSIZE | CSTOPB | PARENB | CRTSCTS);
termios.c_cflag |= (CS8 | CLOCAL | CREAD);
termios.c_lflag &= ~(ISIG | ICANON | IEXTEN);
termios.c_lflag &= ~(ECHO | ECHOE | ECHOK | ECHONL);
termios.c_cc[VMIN] = 0;
termios.c_cc[VTIME] = 10;
switch (m_speed) { ::unlink(m_symlink.c_str());
case 1200U:
::cfsetospeed(&termios, B1200);
::cfsetispeed(&termios, B1200);
break;
case 2400U:
::cfsetospeed(&termios, B2400);
::cfsetispeed(&termios, B2400);
break;
case 4800U:
::cfsetospeed(&termios, B4800);
::cfsetispeed(&termios, B4800);
break;
case 9600U:
::cfsetospeed(&termios, B9600);
::cfsetispeed(&termios, B9600);
break;
case 19200U:
::cfsetospeed(&termios, B19200);
::cfsetispeed(&termios, B19200);
break;
case 38400U:
::cfsetospeed(&termios, B38400);
::cfsetispeed(&termios, B38400);
break;
case 115200U:
::cfsetospeed(&termios, B115200);
::cfsetispeed(&termios, B115200);
break;
case 230400U:
::cfsetospeed(&termios, B230400);
::cfsetispeed(&termios, B230400);
break;
case 460800U:
::cfsetospeed(&termios, B460800);
::cfsetispeed(&termios, B460800);
break;
default:
LogError("Unsupported serial port speed - %u", m_speed);
::close(m_fd);
return false;
}
if (::tcsetattr(m_fd, TCSANOW, &termios) < 0) {
LogError("Cannot set the attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
if (m_assertRTS) {
unsigned int y;
if (::ioctl(m_fd, TIOCMGET, &y) < 0) {
LogError("Cannot get the control attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
y |= TIOCM_RTS;
if (::ioctl(m_fd, TIOCMSET, &y) < 0) {
LogError("Cannot set the control attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
}
}
return true;
} }
#endif #endif

5
PseudoTTYController.h
View file

@ -27,12 +27,15 @@
class CPseudoTTYController : public CSerialController { class CPseudoTTYController : public CSerialController {
public: public:
CPseudoTTYController(const std::string& device, unsigned int speed, bool assertRTS = false); CPseudoTTYController(const std::string& symlink, unsigned int speed, bool assertRTS = false);
virtual ~CPseudoTTYController(); virtual ~CPseudoTTYController();
virtual bool open(); virtual bool open();
virtual void close();
protected: protected:
std::string m_symlink;
}; };
#endif #endif

190
SerialController.cpp
View file

@ -247,101 +247,107 @@ bool CSerialController::open()
return false; return false;
} }
if (::isatty(m_fd)) { if (::isatty(m_fd))
termios termios; return setRaw();
if (::tcgetattr(m_fd, &termios) < 0) {
LogError("Cannot get the attributes for %s", m_device.c_str()); return true;
::close(m_fd); }
return false;
}
termios.c_iflag &= ~(IGNBRK | BRKINT | IGNPAR | PARMRK | INPCK); bool CSerialController::setRaw()
termios.c_iflag &= ~(ISTRIP | INLCR | IGNCR | ICRNL); {
termios.c_iflag &= ~(IXON | IXOFF | IXANY); termios termios;
termios.c_oflag &= ~(OPOST); if (::tcgetattr(m_fd, &termios) < 0) {
termios.c_cflag &= ~(CSIZE | CSTOPB | PARENB | CRTSCTS); LogError("Cannot get the attributes for %s", m_device.c_str());
termios.c_cflag |= (CS8 | CLOCAL | CREAD); ::close(m_fd);
termios.c_lflag &= ~(ISIG | ICANON | IEXTEN); return false;
termios.c_lflag &= ~(ECHO | ECHOE | ECHOK | ECHONL);
#if defined(__APPLE__)
termios.c_cc[VMIN] = 1;
termios.c_cc[VTIME] = 1;
#else
termios.c_cc[VMIN] = 0;
termios.c_cc[VTIME] = 10;
#endif
switch (m_speed) {
case 1200U:
::cfsetospeed(&termios, B1200);
::cfsetispeed(&termios, B1200);
break;
case 2400U:
::cfsetospeed(&termios, B2400);
::cfsetispeed(&termios, B2400);
break;
case 4800U:
::cfsetospeed(&termios, B4800);
::cfsetispeed(&termios, B4800);
break;
case 9600U:
::cfsetospeed(&termios, B9600);
::cfsetispeed(&termios, B9600);
break;
case 19200U:
::cfsetospeed(&termios, B19200);
::cfsetispeed(&termios, B19200);
break;
case 38400U:
::cfsetospeed(&termios, B38400);
::cfsetispeed(&termios, B38400);
break;
case 115200U:
::cfsetospeed(&termios, B115200);
::cfsetispeed(&termios, B115200);
break;
case 230400U:
::cfsetospeed(&termios, B230400);
::cfsetispeed(&termios, B230400);
break;
case 460800U:
::cfsetospeed(&termios, B460800);
::cfsetispeed(&termios, B460800);
break;
default:
LogError("Unsupported serial port speed - %u", m_speed);
::close(m_fd);
return false;
}
if (::tcsetattr(m_fd, TCSANOW, &termios) < 0) {
LogError("Cannot set the attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
if (m_assertRTS) {
unsigned int y;
if (::ioctl(m_fd, TIOCMGET, &y) < 0) {
LogError("Cannot get the control attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
y |= TIOCM_RTS;
if (::ioctl(m_fd, TIOCMSET, &y) < 0) {
LogError("Cannot set the control attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
}
#if defined(__APPLE__)
setNonblock(false);
#endif
} }
termios.c_iflag &= ~(IGNBRK | BRKINT | IGNPAR | PARMRK | INPCK);
termios.c_iflag &= ~(ISTRIP | INLCR | IGNCR | ICRNL);
termios.c_iflag &= ~(IXON | IXOFF | IXANY);
termios.c_oflag &= ~(OPOST);
termios.c_cflag &= ~(CSIZE | CSTOPB | PARENB | CRTSCTS);
termios.c_cflag |= (CS8 | CLOCAL | CREAD);
termios.c_lflag &= ~(ISIG | ICANON | IEXTEN);
termios.c_lflag &= ~(ECHO | ECHOE | ECHOK | ECHONL);
#if defined(__APPLE__)
termios.c_cc[VMIN] = 1;
termios.c_cc[VTIME] = 1;
#else
termios.c_cc[VMIN] = 0;
termios.c_cc[VTIME] = 10;
#endif
switch (m_speed) {
case 1200U:
::cfsetospeed(&termios, B1200);
::cfsetispeed(&termios, B1200);
break;
case 2400U:
::cfsetospeed(&termios, B2400);
::cfsetispeed(&termios, B2400);
break;
case 4800U:
::cfsetospeed(&termios, B4800);
::cfsetispeed(&termios, B4800);
break;
case 9600U:
::cfsetospeed(&termios, B9600);
::cfsetispeed(&termios, B9600);
break;
case 19200U:
::cfsetospeed(&termios, B19200);
::cfsetispeed(&termios, B19200);
break;
case 38400U:
::cfsetospeed(&termios, B38400);
::cfsetispeed(&termios, B38400);
break;
case 115200U:
::cfsetospeed(&termios, B115200);
::cfsetispeed(&termios, B115200);
break;
case 230400U:
::cfsetospeed(&termios, B230400);
::cfsetispeed(&termios, B230400);
break;
case 460800U:
::cfsetospeed(&termios, B460800);
::cfsetispeed(&termios, B460800);
break;
default:
LogError("Unsupported serial port speed - %u", m_speed);
::close(m_fd);
return false;
}
if (::tcsetattr(m_fd, TCSANOW, &termios) < 0) {
LogError("Cannot set the attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
if (m_assertRTS) {
unsigned int y;
if (::ioctl(m_fd, TIOCMGET, &y) < 0) {
LogError("Cannot get the control attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
y |= TIOCM_RTS;
if (::ioctl(m_fd, TIOCMSET, &y) < 0) {
LogError("Cannot set the control attributes for %s", m_device.c_str());
::close(m_fd);
return false;
}
}
#if defined(__APPLE__)
setNonblock(false);
#endif
return true; return true;
} }

1
SerialController.h
View file

@ -59,6 +59,7 @@ protected:
int readNonblock(unsigned char* buffer, unsigned int length); int readNonblock(unsigned char* buffer, unsigned int length);
#else #else
bool canWrite(); bool canWrite();
bool setRaw();
#endif #endif
}; };