The received packet length was stored as unsigned char (max 255) and
used without validating it matches the expected 55-byte DMRD packet
size. Reject packets that don't match the expected length to prevent
stale data reads and silent truncation.
The memcpy writes (length - 4) bytes at offset 8 into a 50-byte buffer,
so the maximum safe length is 46 (8 + 42 = 50), not 50. With length=50
the previous check still allowed a 4-byte stack overflow.
Both functions copy packet data into 50-byte stack buffers without
validating the length parameter. Add bounds checks to reject packets
that would overflow the buffer or cause unsigned underflow.
- Defaut port is 7643 (totally arbitrary)
- Using RemoteCommandDMRG, each network can be enabled or disabled (net1 .. net5, xlx):
~ $ RemoteCommandDMRG 7643 disable net2
M: 2021-03-20 11:48:40.494 Command sent: "disable net2" to port: 7643
M: 2021-03-20 11:48:40.545 OK
- Using RemoteCommandDMRG, a connection status can be retrieved:
~ $ RemoteCommandDMRG 7643 status
M: 2021-03-20 11:49:13.513 Command sent: "status" to port: 7643
M: 2021-03-20 11:49:13.563 xlx:conn net1:conn net2:n/a net3:n/a net4:conn net5:n/a
A returned string is expected from the socket connection, this is why I did not reuse the MMDVMHost's RemoteCommand (unless MMDVMHost RemoteControl is modified as well).
The exit value can be used in scripting (also 1 if we didn't get any reply).
when CUDPSocket::open() is called with m_address (in CUDPSocket) is nothing,
IPv4 socket is created by "0.0.0.0" (INADDR_ANY) address.
This causes a bug that DMRGateway cannot connect to reflector on IPv6.
Avoid this problem, set IP address string to m_socket (in CDMRNetwork) before
calling CUDPSocket::open().
This is a workaround, I think there is better idea.
