dotMorten/NmeaParser
1
0
Fork 0
mirror of https://github.com/dotMorten/NmeaParser.git synced 2025-12-06 07:12:04 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed bug introduced by nullable changes

Browse source
This commit is contained in:
dotMorten 2019-10-03 00:15:16 -07:00
parent 13f8cf9229
commit db3491ecba
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/NmeaParser/NmeaDevice.cs
View file

@ -214,8 +214,8 @@ namespace NmeaParser
}
}
}
if (messageParts != null)
MessageReceived?.Invoke(this, new NmeaMessageReceivedEventArgs(msg, messageParts));
MessageReceived?.Invoke(this, new NmeaMessageReceivedEventArgs(msg, messageParts));
}
private readonly Dictionary<string, Dictionary<int, Nmea.NmeaMessage>> MultiPartMessageCache = new Dictionary<string,Dictionary<int,Nmea.NmeaMessage>>();
@ -289,7 +289,7 @@ namespace NmeaParser
/// </summary>
public sealed class NmeaMessageReceivedEventArgs : EventArgs
{
internal NmeaMessageReceivedEventArgs(Nmea.NmeaMessage message, IReadOnlyList<Nmea.NmeaMessage> messageParts)
internal NmeaMessageReceivedEventArgs(Nmea.NmeaMessage message, IReadOnlyList<Nmea.NmeaMessage>? messageParts)
{
Message = message;
MessageParts = messageParts;
@ -317,6 +317,6 @@ namespace NmeaParser
/// <value>
/// The message parts.
/// </value>
public IReadOnlyList<Nmea.NmeaMessage> MessageParts { get; }
public IReadOnlyList<Nmea.NmeaMessage>? MessageParts { get; }
}
}

5
src/UnitTests/NmeaParser.Tests/DeviceTests.cs
View file

@ -13,6 +13,7 @@ namespace NmeaParser.Tests
{
[TestMethod]
[TestCategory("Device")]
[Timeout(2000)]
public async Task TestGpgsvGroupMessage()
{
var message = "$GPGSV,3,1,9,00,30,055,48,00,19,281,00,27,19,275,00,12,16,319,00*4C\n$GPGSV,3,2,9,00,30,055,48,00,19,281,00,27,19,275,00,12,16,319,00*4F\n$GPGSV,3,3,9,32,10,037,00,,,,,,,,,,,,*74";
@ -50,6 +51,7 @@ namespace NmeaParser.Tests
[TestMethod]
[TestCategory("Device")]
[Timeout(2000)]
public async Task TestMixedGsvGroupMessage()
{
// A group message can have multiple diffent GSV types.
@ -100,7 +102,8 @@ $GAGSV,4,4,14,19,82,349,40,1,44,220,40,4,24,314,38*5F";
[TestMethod]
[TestCategory("Device")]
public async Task TestInvalidGpgsvGroupMessage()
[Timeout(2000)]
public async Task TestInvalidGpgsvGroupMessage()
{
var message = "$GPGSV,3,2,9,00,30,055,48,00,19,281,00,27,19,275,00,12,16,319,00*4D\n$GPGSV,3,2,9,00,30,055,48,00,19,281,00,27,19,275,00,12,16,319,00*4F\n$GPGSV,3,3,9,32,10,037,00,,,,,,,,,,,,*74";
NmeaDevice dev = new BufferedStringDevice(message);