RPCS3/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2025-12-06 07:12:28 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

SPU Analyzer: Try to detect no-return in BISL/BRSL

Browse source
This commit is contained in:
Elad 2025-11-22 11:21:06 +02:00
parent 7b560e5ffa
commit 727f3dd7a1
1 changed files with 71 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

76
rpcs3/Emu/Cell/SPUCommonRecompiler.cpp
View file

@ -3069,6 +3069,39 @@ spu_program spu_recompiler_base::analyse(const be_t<u32>* ls, u32 entry_point, s
values[op.rt] = pos + 4; values[op.rt] = pos + 4;
} }
const u32 pos_next = wa;
bool is_no_return = false;
if (pos_next >= lsa && pos_next < limit)
{
const u32 data_next = ls[pos_next / 4];
const auto type_next = g_spu_itype.decode(data_next);
const auto flag_next = g_spu_iflag.decode(data_next);
const auto op_next = spu_opcode_t{data_next};
if (!(type_next & spu_itype::zregmod) && !(type_next & spu_itype::branch))
{
if (auto iflags = g_spu_iflag.decode(data_next))
{
if (+flag_next & +spu_iflag::use_ra)
{
is_no_return = is_no_return || (op_next.ra >= 4 && op_next.ra < 10);
}
if (+flag_next & +spu_iflag::use_rb)
{
is_no_return = is_no_return || (op_next.rb >= 4 && op_next.rb < 10);
}
if (type_next & spu_itype::_quadrop && +iflags & +spu_iflag::use_rc)
{
is_no_return = is_no_return || (op_next.ra >= 4 && op_next.rb < 10);
}
}
}
}
if (af & vf::is_const) if (af & vf::is_const)
{ {
const u32 target = spu_branch_target(av); const u32 target = spu_branch_target(av);
@ -3105,7 +3138,7 @@ spu_program spu_recompiler_base::analyse(const be_t<u32>* ls, u32 entry_point, s
limit = std::min<u32>(limit, target); limit = std::min<u32>(limit, target);
} }
if (sl && g_cfg.core.spu_block_size != spu_block_size_type::safe) if (!is_no_return && sl && g_cfg.core.spu_block_size != spu_block_size_type::safe)
{ {
m_ret_info[pos / 4 + 1] = true; m_ret_info[pos / 4 + 1] = true;
m_entry_info[pos / 4 + 1] = true; m_entry_info[pos / 4 + 1] = true;
@ -3294,9 +3327,9 @@ spu_program spu_recompiler_base::analyse(const be_t<u32>* ls, u32 entry_point, s
spu_log.notice("[0x%x] At 0x%x: ignoring indirect branch (SYNC)", entry_point, pos); spu_log.notice("[0x%x] At 0x%x: ignoring indirect branch (SYNC)", entry_point, pos);
} }
if (type == spu_itype::BI || sl) if (type == spu_itype::BI || sl || is_no_return)
{ {
if (type == spu_itype::BI || g_cfg.core.spu_block_size == spu_block_size_type::safe) if (type == spu_itype::BI || g_cfg.core.spu_block_size == spu_block_size_type::safe || is_no_return)
{ {
m_targets[pos]; m_targets[pos];
} }
@ -3333,9 +3366,42 @@ spu_program spu_recompiler_base::analyse(const be_t<u32>* ls, u32 entry_point, s
break; break;
} }
const u32 pos_next = wa;
bool is_no_return = false;
if (pos_next >= lsa && pos_next < limit)
{
const u32 data_next = ls[pos_next / 4];
const auto type_next = g_spu_itype.decode(data_next);
const auto flag_next = g_spu_iflag.decode(data_next);
const auto op_next = spu_opcode_t{data_next};
if (!(type_next & spu_itype::zregmod) && !(type_next & spu_itype::branch))
{
if (auto iflags = g_spu_iflag.decode(data_next))
{
if (+flag_next & +spu_iflag::use_ra)
{
is_no_return = is_no_return || (op_next.ra >= 4 && op_next.ra < 10);
}
if (+flag_next & +spu_iflag::use_rb)
{
is_no_return = is_no_return || (op_next.rb >= 4 && op_next.rb < 10);
}
if (type_next & spu_itype::_quadrop && +iflags & +spu_iflag::use_rc)
{
is_no_return = is_no_return || (op_next.rc >= 4 && op_next.rc < 10);
}
}
}
}
m_targets[pos].push_back(target); m_targets[pos].push_back(target);
if (g_cfg.core.spu_block_size != spu_block_size_type::safe) if (!is_no_return && g_cfg.core.spu_block_size != spu_block_size_type::safe)
{ {
m_ret_info[pos / 4 + 1] = true; m_ret_info[pos / 4 + 1] = true;
m_entry_info[pos / 4 + 1] = true; m_entry_info[pos / 4 + 1] = true;
@ -3343,7 +3409,7 @@ spu_program spu_recompiler_base::analyse(const be_t<u32>* ls, u32 entry_point, s
add_block(pos + 4); add_block(pos + 4);
} }
if (g_cfg.core.spu_block_size == spu_block_size_type::giga && !sync) if (!is_no_return && g_cfg.core.spu_block_size == spu_block_size_type::giga && !sync)
{ {
m_entry_info[target / 4] = true; m_entry_info[target / 4] = true;
add_block(target); add_block(target);