RPCS3/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2026-04-18 04:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

rsx/fp: Stop referencing wpos when the value is just getting discarded.

Browse source
This commit is contained in:
kd-11 2025-12-13 14:37:01 +03:00 • committed by kd-11
parent 5e4c2433c1
commit 308adca206
1 changed files with 28 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

36
rpcs3/Emu/RSX/Program/FragmentProgramDecompiler.cpp
View file

@ -551,18 +551,22 @@ template<typename T> std::string FragmentProgramDecompiler::GetSRC(T src)
{ {
std::string ret; std::string ret;
u32 precision_modifier = 0; u32 precision_modifier = 0;
u32 register_index = umax;
if constexpr (std::is_same_v<T, SRC0>) if constexpr (std::is_same_v<T, SRC0>)
{ {
precision_modifier = src1.src0_prec_mod; precision_modifier = src1.src0_prec_mod;
register_index = 0;
} }
else if constexpr (std::is_same_v<T, SRC1>) else if constexpr (std::is_same_v<T, SRC1>)
{ {
precision_modifier = src1.src1_prec_mod; precision_modifier = src1.src1_prec_mod;
register_index = 1;
} }
else if constexpr (std::is_same_v<T, SRC2>) else if constexpr (std::is_same_v<T, SRC2>)
{ {
precision_modifier = src1.src2_prec_mod; precision_modifier = src1.src2_prec_mod;
register_index = 2;
} }
switch (src.reg_type) switch (src.reg_type)
@ -645,18 +649,29 @@ template<typename T> std::string FragmentProgramDecompiler::GetSRC(T src)
{ {
// TEX0 - TEX9 // TEX0 - TEX9
// Texcoord 2d mask seems to reset the last 2 arguments to 0 and w if set // Texcoord 2d mask seems to reset the last 2 arguments to 0 and w if set
// Opt: Skip emitting w dependency unless w coord is actually being sampled
ensure(register_index != umax);
const auto lane_mask = FP::get_src_vector_lane_mask_shuffled(m_prog, m_instruction, register_index);
const auto touches_z = !!(lane_mask & (1u << 2));
const bool touches_w = !!(lane_mask & (1u << 3));
const u8 texcoord = u8(register_id) - 4; const u8 texcoord = u8(register_id) - 4;
if (m_prog.texcoord_is_point_coord(texcoord)) if (m_prog.texcoord_is_point_coord(texcoord))
{ {
// Point sprite coord generation. Stacks with the 2D override mask. // Point sprite coord generation. Stacks with the 2D override mask.
if (m_prog.texcoord_is_2d(texcoord)) if (!m_prog.texcoord_is_2d(texcoord))
{ {
ret += getFloatTypeName(4) + "(gl_PointCoord, 0., in_w)"; ret += getFloatTypeName(4) + "(gl_PointCoord, 1., 0.)";
properties.has_w_access = true; }
else if (!touches_w)
{
ret += getFloatTypeName(4) + "(gl_PointCoord, 0., 0.)";
} }
else else
{ {
ret += getFloatTypeName(4) + "(gl_PointCoord, 1., 0.)"; ret += getFloatTypeName(4) + "(gl_PointCoord, 0., in_w)";
properties.has_w_access = true;
} }
} }
else if (src2.perspective_corr) else if (src2.perspective_corr)
@ -673,14 +688,19 @@ template<typename T> std::string FragmentProgramDecompiler::GetSRC(T src)
} }
else else
{ {
if (m_prog.texcoord_is_2d(texcoord)) const bool skip_zw_load = !touches_z && !touches_w;
if (!m_prog.texcoord_is_2d(texcoord) || skip_zw_load)
{ {
ret += getFloatTypeName(4) + "(" + reg_var + ".xy, 0., in_w)"; ret += reg_var;
properties.has_w_access = true; }
else if (!touches_w)
{
ret += getFloatTypeName(4) + "(" + reg_var + ".xy, 0., 0.)";
} }
else else
{ {
ret += reg_var; ret += getFloatTypeName(4) + "(" + reg_var + ".xy, 0., in_w)";
properties.has_w_access = true;
} }
} }
break; break;