Commit graph

482 commits

Author SHA1 Message Date
Mark Landis (N6AZX) af7ed717b4 CDmridDir destructor should be virtual
CDmridDir is a base class for CDmridDirHttp and CDmridDirFile, so
its destructor should be marked virtual to prevent undefined behavior.
2022-12-31 08:16:35 -08:00
Mark Landis (N6AZX) 08d1ff5df0 isdigit() may return any non-zero result for success
POSIX states that the return value of isdigit(): "shall return non-zero
if c is a decimal digit; otherwise, they shall return 0."

Thus the form:

  ok &= isdigit(x)

is invalid since the runtime is not required to return 1.

This bug was observed on Debian 11 while using the clang toolchain.
In that environment, isdigit() returns 2048 for a positive match.
2022-12-27 15:04:09 -08:00
Mark Landis (N6AZX) d4c72fd623 Default initialize class thread variables
During testing in a sandbox environment, xlxd crashed in
CG3Protocol::Close(). The root cause was dereferencing
m_pPresenceThread when the object had never been initialized.
In this case an error occured during ::Init() which set ok=false,
so the initialization of the threads was skipped.

This commit does 3 things:

(1) Default initializes the thread pointers to avoid the crash.
(2) Wraps the thread allocation with try/catch since std::thread can
    throw.
(3) Does some light cleaning in ::Close, e.g., converting NULL to
    nullptr.
2022-12-17 14:58:25 -08:00
LX1IQ 6752c7b254
Update main.h 2022-12-08 07:22:27 +01:00
LX1IQ d7daeb0c52
Update main.h 2022-12-08 07:20:10 +01:00
narspt 88ab5d4571 fix occasional ambed crash when device fails init 2022-09-12 07:57:01 +01:00
narspt 713da9ffae make ambed more robust to handle device errors 2022-09-02 00:07:07 +01:00
narspt 99530863d5 fix openstream timeout issue 2022-08-19 21:22:10 +01:00
narspt f9a46808a3
remove unused constants on ambed main.h
these are only used on xlxd and ambedtest, not at ambed... they may just confuse users trying to tweak something that does nothing.
2022-07-23 22:56:17 +01:00
LX1IQ adec5c8d14
Merge pull request #218 from narspt/patch-18
add missing UK prefixes and sync db1/db2 country.csv
2022-05-04 07:28:18 +02:00
narspt 53165886af
update/sync country.csv for dashboard2 2022-05-04 00:14:47 +01:00
narspt 4526461b02
add missing UK prefixes and sync Malaysia from db2 2022-05-04 00:10:28 +01:00
narspt aca0e5fba3
add extra blank line after ftdi devices list 2022-04-02 23:01:45 +01:00
narspt 247471c15b
Update cvocodecinterface.h 2022-04-02 22:55:55 +01:00
narspt 0b0cbec470
add device serial to vocodec open/close log msgs
this allows to identify what device is being used exactly, printing just the device name can't identify it if we have multiple similar devices...
2022-04-02 22:51:23 +01:00
narspt 3801ffdec5
cleanly print out ambe model and version
instead of raw printing whole ambe control packet reply, including non-printable chars, field identifiers and even parity byte...
2022-04-02 22:13:07 +01:00
narspt 60f167b339
log IP of the client reflector opening stream 2022-04-02 22:05:28 +01:00
narspt 4f88437ee8
fix error msg showing client ip instead of local 2022-04-02 22:00:27 +01:00
narspt b962b4883e
fix ambed to allow it to be used by multiple xlxd
the static Ip var was being shared by all instances of cstream class, then using same ambed by multiple xlxd's (on different ip's) would be a problem, we can just use m_Ip (that already stores the ip of the client reflector, set by controller class when creating cstream) to send packets back
2022-04-02 21:55:41 +01:00
narspt ee95248e95
fix m_uiYsfPacketFrameId and m_uiImrsPacketFrameId
to match the change on m_uiPacketCntr
2022-02-06 21:08:53 +00:00
narspt 3de68cd506
fix frame sequence applied by UpdatePids() 2022-02-06 21:00:15 +00:00
narspt 0fe726479c
Update cdmrmmdvmprotocol.h 2022-02-06 08:21:45 +00:00
narspt 84ed362863
add embedded LC data for DMRmmdvm 2022-02-06 08:14:14 +00:00
LX1IQ 53fdde921e
Merge pull request #211 from yl3im/master
Update callsign prefixes for Russia.
2021-12-17 06:41:50 +01:00
Inga Muste 2fc8bf65bf Update callsign prefixes for Russia. 2021-12-17 00:15:21 +02:00
LX3JL e87eb8e3dd
Merge pull request #209 from narspt/patch-14
change SetYsfCallsign() to trim callsign on null char
2021-11-18 12:57:31 +01:00
narspt a44697cb46
xlxd 2.5.2 2021-11-18 04:33:03 +00:00
narspt d9402c1aeb
change SetYsfCallsign() to trim callsign on null char 2021-11-18 00:45:54 +00:00
LX3JL 2fd3d875dc xlxd 2.5.1
Corrected issue with IMRS repeataer disconnecting during very long QSO
2021-11-07 11:07:30 +01:00
LX3JL 190021cc29
Merge pull request #206 from jimt/patch-1
fix Linux AF_INET iteration segfault
2021-11-05 11:01:50 +01:00
Jim Tittsler f8644e1f1f
fix Linux AF_INET iteration segfault
Prevent segfault when WireGuard is active and an interface has `ifaptr->ifa_addr == NULL`
2021-11-05 13:07:07 +09:00
LX1IQ 2a67aa7138
Update README.md 2021-11-04 07:23:17 +01:00
LX3JL a64b20bc07
Merge pull request #202 from LX3JL/IMRS
implementation of Yaesu's IRMS protocol
2021-10-31 12:36:26 +01:00
LX3JL c3de5fa893 corrected deadloop in CImrsProtocol::EncodePongPacket() 2021-10-30 23:09:48 +02:00
LX3JL b411eb8b8a corrected bug preventing relaying streams on module 'A' of IMRS clients
corrected bug xlxd not advertising module W,X,Y & Z to IMRS clients
2021-10-30 18:21:05 +02:00
LX3JL 0eea5d7bf9
Merge pull request #203 from narspt/patch-13
fix SetYsfCallsign() missing dmrid update
2021-10-29 18:01:09 +02:00
narspt 43c1a10832
fix SetYsfCallsign() missing dmrid update
this caused YSF transmissions to show-up on DMR listeners with dmrid 0
2021-10-28 23:07:52 +01:00
LX3JL a45cdff2d2 implementation of Yaesu's IRMS protocol 2021-10-26 20:36:29 +02:00
LX1IQ 0369eba38c
Update README.md 2021-10-21 07:31:28 +02:00
LX1IQ 0b2c40a7fd
Delete sx.png 2021-10-12 08:01:10 +02:00
LX1IQ a3dc643299
Delete ss.png 2021-10-12 08:00:59 +02:00
LX1IQ 639471c639
Delete pn.png 2021-10-12 08:00:48 +02:00
LX1IQ 28e617aba9
Delete pf.png 2021-10-12 08:00:37 +02:00
LX1IQ 6fda922a8a
Delete ps.png 2021-10-12 08:00:27 +02:00
LX1IQ 97172695bd
Delete nu.png 2021-10-12 08:00:17 +02:00
LX1IQ 0004ba22a6
Delete nf.png 2021-10-12 08:00:07 +02:00
LX1IQ 67c05506df
Delete ms.png 2021-10-12 07:59:55 +02:00
LX1IQ ba823b1223
Delete tc.png 2021-10-12 07:59:45 +02:00
LX1IQ de2f528923
Delete mp.png 2021-10-12 07:59:31 +02:00
LX1IQ 8ac4ec39b1
Delete mf.png 2021-10-12 07:59:21 +02:00