change decoder strategy

boswatch/decoder/decoder.py

@@ -16,42 +16,25 @@
 """
 import logging
 
-from boswatch.decoder.fms import Fms
+from boswatch.decoder.fmsdecoder import FmsDecoder
-from boswatch.decoder.pocsag import Pocsag
+from boswatch.decoder.pocsagdecoder import PocsagDecoder
-from boswatch.decoder.zvei import Zvei
+from boswatch.decoder.zveidecoder import ZveiDecoder
 
 logging.debug("- %s loaded", __name__)
 
 
-def getDecoder(data):
+def decode(data):
-    """!Choose the right decoder and return the new decoder object
+    """!Choose the right decoder and return a bwPacket instance
 
     @param data: data to decode
-    @return Decoder object"""
+    @return bwPacket instance"""
     logging.debug("search decoder")
     if "FMS" in data:
-        return Fms()
+        return FmsDecoder.decode(data)
     elif "POCSAG" in data:
-        return Pocsag()
+        return PocsagDecoder.decode(data)
     elif "ZVEI" in data:
-        return Zvei()
+        return ZveiDecoder.decode(data)
     else:
-        logging.debug("no decoder found for: %s", data)
+        logging.error("no decoder found for: %s", data)
-        return DummyDecoder()
+        return False
-
-
-class DummyDecoder:
-    """!This dummy decoder class is needed because in case of
-    an getDecoder() with false data, we must return a decoder
-    object with an decode() method to prevent an error"""
-    def __init__(self):
-        """!Do nothing"""
-        pass
-
-    @staticmethod
-    def decode(data):
-        """!Dummy decode() method
-
-        @param data: data to decode
-        @return ALWAYS None"""
-        return None

boswatch/decoder/fmsdecoder.py

@@ -23,7 +23,7 @@ from boswatch.packet import packet
 logging.debug("- %s loaded", __name__)
 
 
-class Fms:
+class FmsDecoder:
     """!FMS decoder class
 
     This class decodes FMS data.

boswatch/decoder/pocsagdecoder.py

@@ -23,7 +23,7 @@ from boswatch.packet import packet
 logging.debug("- %s loaded", __name__)
 
 
-class Pocsag:
+class PocsagDecoder:
     """!POCSAG decoder class
 
     This class decodes POCSAG data.
@@ -40,7 +40,7 @@ class Pocsag:
 
         @param data: POCSAG for decoding
         @return BOSWatch POCSAG packet or None"""
-        bitrate, ric, subric = Pocsag._getBitrateRicSubric(data)
+        bitrate, ric, subric = PocsagDecoder._getBitrateRicSubric(data)
 
         if re.search("[0-9]{7}", ric) and re.search("[1-4]", subric):
             if "Alpha:" in data:

boswatch/decoder/zveidecoder.py

@@ -23,7 +23,7 @@ from boswatch.packet import packet
 logging.debug("- %s loaded", __name__)
 
 
-class Zvei:
+class ZveiDecoder:
     """!ZVEI decoder class
 
     This class decodes ZVEI data.
@@ -46,7 +46,7 @@ class Zvei:
 
             bwPacket = packet.Packet()
             bwPacket.set("mode", "zvei")
-            bwPacket.set("zvei", Zvei._solveDoubleTone(data[7:12]))
+            bwPacket.set("zvei", ZveiDecoder._solveDoubleTone(data[7:12]))
 
             logging.debug(bwPacket)
             return bwPacket

bw_client.py

@@ -84,7 +84,7 @@ try:
                 print("Alarm Nr #" + str(i))
 
                 data = "ZVEI1: 12345"
-                bwPacket = decoder.getDecoder(data).decode(data)
+                bwPacket = decoder.decode(data)
 
                 if bwPacket:
                     bwPacket.printInfo()