From 1d90b3d38b2dde6d3380a7bf89de9d35a57a5b2d Mon Sep 17 00:00:00 2001 From: Bastian Schroll Date: Wed, 23 Oct 2019 22:11:57 +0200 Subject: [PATCH] fix some pyflakes --- test/boswatch/test_ServerClient.py | 4 ++-- test/boswatch/test_config.py | 2 +- test/boswatch/test_packet.py | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/test/boswatch/test_ServerClient.py b/test/boswatch/test_ServerClient.py index 0c8fdcc..ce70247 100644 --- a/test/boswatch/test_ServerClient.py +++ b/test/boswatch/test_ServerClient.py @@ -186,7 +186,7 @@ def test_serverStopsWhileConnected(getRunningServer, getClient): while getClient.isConnected: time.sleep(0.1) timeout = timeout - 1 - if timeout is 0: + if timeout == 0: break assert timeout @@ -210,7 +210,7 @@ def test_serverGetOutput(getRunningServer): assert getRunningServer._alarmQueue.qsize() == 2 assert getRunningServer._alarmQueue.get(True, 1)[1] == "test1" assert getRunningServer._alarmQueue.get(True, 1)[1] == "test2" - assert getRunningServer._alarmQueue.qsize() is 0 # Last _check must be None + assert getRunningServer._alarmQueue.qsize() == 0 # Last _check must be None # disconnect all assert testClient1.disconnect() assert testClient2.disconnect() diff --git a/test/boswatch/test_config.py b/test/boswatch/test_config.py index 80fb346..b58139b 100644 --- a/test/boswatch/test_config.py +++ b/test/boswatch/test_config.py @@ -89,7 +89,7 @@ def test_configIterationList(getFilledConfig): for item in getFilledConfig.get("list"): assert type(item) is str counter += 1 - assert counter is 3 + assert counter == 3 def test_configIterationListWithNestedList(getFilledConfig): diff --git a/test/boswatch/test_packet.py b/test/boswatch/test_packet.py index ee638fd..fc36c02 100644 --- a/test/boswatch/test_packet.py +++ b/test/boswatch/test_packet.py @@ -34,19 +34,19 @@ def buildPacket(): def test_createPacket(buildPacket): """!Create a packet""" - assert buildPacket is not "" + assert buildPacket != "" def test_copyPacket(buildPacket): """!Copy a packet to an new instance""" bwCopyPacket = Packet(buildPacket.__str__()) - assert bwCopyPacket is not "" + assert bwCopyPacket != "" def test_getPacketString(buildPacket): """!get the intern packet dict as string""" assert type(buildPacket.__str__()) is str - assert buildPacket.__str__() is not "" + assert buildPacket.__str__() != "" def test_getNotSetField(buildPacket): @@ -57,4 +57,4 @@ def test_getNotSetField(buildPacket): def test_setGetField(buildPacket): """!set and get a field""" buildPacket.set("testField", "test") - assert buildPacket.get("testField") is "test" + assert buildPacket.get("testField") == "test"